Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: fix and simply ccache version getter #1300

Closed
wants to merge 1 commit into from

Conversation

maclover7
Copy link
Contributor

@rvagg This was what I meant in #1277 -- for some reason the awk script doesn't work on my Mac, and this will help to simplify what we're actually trying to do here

LucaLanziani

This comment was marked as off-topic.

@LucaLanziani
Copy link
Contributor

One issue I can see with this, if I'm reading the code correctly, is that we are assuming that the moment the tag is in GitHub the tar.gz is already in the "samba ftp" endpoint.

@refack
Copy link
Contributor

refack commented Jun 3, 2018

How about splitting this to:

  1. A script that fetches whatever version and stores it in a known location (e.g. www/downloads)
  2. Ansible can always fetch from known location.

@LucaLanziani
Copy link
Contributor

@refack would the script fetch the version on every run?

At the end I've decided to push my version too #1312 ;)

@refack
Copy link
Contributor

refack commented Jun 3, 2018

refack would the script fetch the version on every run?

That's an interesting question, since we don't have a defined schedule for updates. I'd say a fetch script could be manually triggered, and ansible stays the same.

But I saw 1312, and if it's that simple it's better.

P.S. only issue we might have is that some machines have old openSSL and have trouble reaching https hosts, so we might need to cache stuff on www/downloads.

@rvagg
Copy link
Member

rvagg commented Jun 12, 2018

oh, whoops, this must work for me because I have coreutils installed on my mac and they are the default executables so it's consistent between my mac and linux machines. +1 on whatever works.

@maclover7
Copy link
Contributor Author

Closing in favor of #1312

@maclover7 maclover7 closed this Jun 12, 2018
@maclover7 maclover7 deleted the jm-fix-ccache branch June 12, 2018 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants