Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add libc::IP6T_SO_ORIGINAL_DST to socket opt #1490

Merged
merged 2 commits into from
Aug 18, 2021
Merged

Conversation

bearice
Copy link
Contributor

@bearice bearice commented Aug 11, 2021

the original PR #1410 was stalled for a while
let's make it happen.

this should closes #1410 and #938

@asomers
Copy link
Member

asomers commented Aug 14, 2021

What does that sockopt do, anyway? I can't find it in any man pages.

@bearice
Copy link
Contributor Author

bearice commented Aug 14, 2021

It's an IPv6 version of SO_ORIGINAL_DST

According to rust-lang/libc#1650 it has same value with SO_ORIGINAL_DST, but when used with SOL_IPV6, it returns a sockaddr_in6 instead of a sockaddr_in

Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Aug 18, 2021
1490: add libc::IP6T_SO_ORIGINAL_DST to socket opt r=asomers a=bearice

the original PR #1410 was stalled for a while
let's make it happen.

this should closes #1410 and #938

Co-authored-by: Icemic <[email protected]>
Co-authored-by: Bearice Ren <[email protected]>
@asomers
Copy link
Member

asomers commented Aug 18, 2021

bors is confused. It doesn't realize that the iOS and OSX builds have finished. Let's start over.

bors r-

@bors
Copy link
Contributor

bors bot commented Aug 18, 2021

Canceled.

@asomers
Copy link
Member

asomers commented Aug 18, 2021

bors r+

bors bot added a commit that referenced this pull request Aug 18, 2021
1490: add libc::IP6T_SO_ORIGINAL_DST to socket opt r=asomers a=bearice

the original PR #1410 was stalled for a while
let's make it happen.

this should closes #1410 and #938

Co-authored-by: Icemic <[email protected]>
Co-authored-by: Bearice Ren <[email protected]>
@asomers
Copy link
Member

asomers commented Aug 18, 2021

bors r-

@bors
Copy link
Contributor

bors bot commented Aug 18, 2021

Canceled.

@asomers
Copy link
Member

asomers commented Aug 18, 2021

bors r+

bors bot added a commit that referenced this pull request Aug 18, 2021
1486: Relax assertions in sockaddr_storage_to_addr to match the documentation. r=asomers a=khuey

Fixes #1479

1490: add libc::IP6T_SO_ORIGINAL_DST to socket opt r=asomers a=bearice

the original PR #1410 was stalled for a while
let's make it happen.

this should closes #1410 and #938

1493: Fix crates.io badge r=asomers a=atouchet



Co-authored-by: Kyle Huey <[email protected]>
Co-authored-by: Icemic <[email protected]>
Co-authored-by: Bearice Ren <[email protected]>
Co-authored-by: Alex Touchet <[email protected]>
@bors
Copy link
Contributor

bors bot commented Aug 18, 2021

This PR was included in a batch that timed out, it will be automatically retried

bors bot added a commit that referenced this pull request Aug 18, 2021
1490: add libc::IP6T_SO_ORIGINAL_DST to socket opt r=asomers a=bearice

the original PR #1410 was stalled for a while
let's make it happen.

this should closes #1410 and #938

1493: Fix crates.io badge r=asomers a=atouchet



Co-authored-by: Icemic <[email protected]>
Co-authored-by: Bearice Ren <[email protected]>
Co-authored-by: Alex Touchet <[email protected]>
@bors
Copy link
Contributor

bors bot commented Aug 18, 2021

This PR was included in a batch that timed out, it will be automatically retried

bors bot added a commit that referenced this pull request Aug 18, 2021
1490: add libc::IP6T_SO_ORIGINAL_DST to socket opt r=asomers a=bearice

the original PR #1410 was stalled for a while
let's make it happen.

this should closes #1410 and #938

Co-authored-by: Icemic <[email protected]>
Co-authored-by: Bearice Ren <[email protected]>
@bors
Copy link
Contributor

bors bot commented Aug 18, 2021

Timed out.

@asomers
Copy link
Member

asomers commented Aug 18, 2021

bors retry

@bors bors bot merged commit 7207004 into nix-rust:master Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants