Relax assertions in sockaddr_storage_to_addr to match the documentation. #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asomers
requested changes
Aug 10, 2021
asomers
requested changes
Aug 14, 2021
test/sys/test_socket.rs
Outdated
| let storage_ptr = storage.as_mut_ptr().cast::<sockaddr_in6>(); | ||
| let (ffi_ptr, ffi_size) = sockaddr.as_ffi_pair(); | ||
| // XXX this does not pass. | ||
| // assert_eq!(mem::size_of::<sockaddr>(), ffi_size as usize); |
|
You'll need to rebase to fix the test failures. |
|
Done. |
|
Just one more thing: would you mind squashing your commits? |
|
Done. |
bors bot
added a commit
that referenced
this pull request
Aug 18, 2021
1486: Relax assertions in sockaddr_storage_to_addr to match the documentation. r=asomers a=khuey Fixes #1479 1490: add libc::IP6T_SO_ORIGINAL_DST to socket opt r=asomers a=bearice the original PR #1410 was stalled for a while let's make it happen. this should closes #1410 and #938 1493: Fix crates.io badge r=asomers a=atouchet Co-authored-by: Kyle Huey <[email protected]> Co-authored-by: Icemic <[email protected]> Co-authored-by: Bearice Ren <[email protected]> Co-authored-by: Alex Touchet <[email protected]>
|
This PR was included in a batch that timed out, it will be automatically retried |
bors bot
added a commit
that referenced
this pull request
Aug 18, 2021
1486: Relax assertions in sockaddr_storage_to_addr to match the documentation. r=asomers a=khuey Fixes #1479 Co-authored-by: Kyle Huey <[email protected]>
|
Timed out. |
|
bors retry |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1479