Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings on Rust 1.37.0 #1095

Merged
merged 3 commits into from
Jul 13, 2019
Merged

Fix warnings on Rust 1.37.0 #1095

merged 3 commits into from
Jul 13, 2019

Conversation

asomers
Copy link
Member

@asomers asomers commented Jul 2, 2019

  • Replace obsolete range syntax "..." with inclusive range "..="
  • Use dyn Trait syntax instead of Box
  • Raise MSRV to 1.27.0 (for dyn Trait syntax)
  • Test with nightly again

@asomers asomers added this to the 0.15.0 milestone Jul 11, 2019
asomers added 3 commits July 13, 2019 15:05
@asomers
Fix warnings on Rust 1.37.0
c156af5 
* Replace obsolete range syntax "..." with inclusive range "..="
* Use dyn Trait syntax instead of Box<Trait>
* Raise MSRV to 1.27.0 (for dyn Trait syntax)
* Raise MSRV to 1.31.0 (because of rand)

tempfile pulls in rand, and rand pulls in fuchsia-cprng, which requires
1.31.0.  Why rand pulls in fuchsia-cprng I don't know.  It's specified
as a target-specific dependency, but Cargo tries to build it anyway
(only on Linux, not on FreeBSD or OSX).  A bug in Cargo 1.27.0?
@asomers
Do "cargo check" instead of "cargo build" for the MSRV check
43df789 
check is faster than build.
@asomers
Temporarily allow deprecated items
2373ac8 
This fixes the tests on Rust 1.38.0.  We'll fix them for real after
release 0.15.0.

Issue nix-rust#1096
@asomers
Copy link
Member Author

asomers commented Jul 13, 2019

bors r+

bors bot added a commit that referenced this pull request Jul 13, 2019
@bors @asomers
Merge #1095
96ae786 
1095: Fix warnings on Rust 1.37.0 r=asomers a=asomers

* Replace obsolete range syntax "..." with inclusive range "..="
* Use dyn Trait syntax instead of Box<Trait>
* Raise MSRV to 1.27.0 (for dyn Trait syntax)
* Test with nightly again

Co-authored-by: Alan Somers <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jul 13, 2019

Build succeeded

@bors bors bot merged commit 2373ac8 into nix-rust:master Jul 13, 2019
@asomers asomers deleted the nightly_1.37.0 branch July 14, 2019 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
1 participant
@asomers