Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all calls to mem::uninitialized with MaybeUninit #1096

Closed
asomers opened this issue Jul 7, 2019 · 0 comments
Closed

Replace all calls to mem::uninitialized with MaybeUninit #1096

asomers opened this issue Jul 7, 2019 · 0 comments
Milestone
0.16.0

Comments

@asomers
Copy link
Member

asomers commented Jul 7, 2019

Rust will deprecate mem::uninitialized beginning with Rust 1.38.0. The recommended replacement is MaybeUninit. Unfortunately, MaybeUninit was only introduced in Rust 1.36.0. So we'll have to raise the MSRV. We should therefore wait to fix this issue until shortly before 1.38.0 is released, which will be sometime around September-29.
https://blog.rust-lang.org/2019/07/04/Rust-1.36.0.html
@asomers asomers mentioned this issue Jul 7, 2019
Closed
@asomers asomers modified the milestones: 1.0, 0.16.0 Jul 11, 2019
asomers added a commit to asomers/nix that referenced this issue Jul 11, 2019
@asomers
Temporarily allow deprecated items
e76d5a0 
This fixes the tests on Rust 1.38.0.  We'll fix them for real after
release 0.15.0.

Issue nix-rust#1096
asomers added a commit to asomers/nix that referenced this issue Jul 13, 2019
@asomers
Temporarily allow deprecated items
36f688f 
This fixes the tests on Rust 1.38.0.  We'll fix them for real after
release 0.15.0.

Issue nix-rust#1096
asomers added a commit to asomers/nix that referenced this issue Jul 13, 2019
@asomers
Temporarily allow deprecated items
2373ac8 
This fixes the tests on Rust 1.38.0.  We'll fix them for real after
release 0.15.0.

Issue nix-rust#1096
scottlamb pushed a commit to scottlamb/nix that referenced this issue Jul 17, 2019
@asomers @scottlamb
Temporarily allow deprecated items
1f75da7 
This fixes the tests on Rust 1.38.0.  We'll fix them for real after
release 0.15.0.

Issue nix-rust#1096
@asomers asomers mentioned this issue Jul 24, 2019
Closed
asomers added a commit to asomers/nix that referenced this issue Sep 3, 2019
@asomers
Replace most instances of mem::uninitialized with mem::MaybeUninit
53a0ffc 
Only two instances remain:

* For the deprecated sys::socket::CmsgSpace::new.  We should probably
  just remove that method.

* For sys::termios::Termios::default_uninit.  This will require some
  more thought.

Fixes nix-rust#1096
@bors bors bot closed this as completed in 4690324 Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.16.0
Development

No branches or pull requests
1 participant
@asomers