Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: Lint and style check full repository #3221

Merged
merged 7 commits into from
Feb 6, 2024
Merged

Conversation

effigies
Copy link
Member

@effigies effigies commented Feb 5, 2024

Including the wrapper here. No upgrades permitted, to maintain Python 2 compatibility.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 196 lines in your changes are missing coverage. Please review.

Comparison is base (f3e95d9) 72.60% compared to head (44ff6d0) 73.28%.
Report is 19 commits behind head on master.

Files Patch % Lines
fmriprep/cli/run.py 0.00% 32 Missing ⚠️
fmriprep/cli/workflow.py 0.00% 26 Missing ⚠️
fmriprep/config.py 72.30% 18 Missing ⚠️
fmriprep/interfaces/workbench.py 55.00% 18 Missing ⚠️
fmriprep/cli/parser.py 67.34% 16 Missing ⚠️
fmriprep/utils/bids.py 23.07% 10 Missing ⚠️
fmriprep/utils/telemetry.py 18.18% 9 Missing ⚠️
fmriprep/workflows/base.py 52.94% 8 Missing ⚠️
fmriprep/workflows/bold/confounds.py 71.42% 8 Missing ⚠️
fmriprep/interfaces/resampling.py 71.42% 6 Missing ⚠️
... and 18 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3221      +/-   ##
==========================================
+ Coverage   72.60%   73.28%   +0.68%     
==========================================
  Files          56       55       -1     
  Lines        4241     4174      -67     
==========================================
- Hits         3079     3059      -20     
+ Misses       1162     1115      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit 74192fb into nipreps:master Feb 6, 2024
16 of 17 checks passed
@effigies effigies added this to the 24.0.0 milestone Mar 4, 2024
effigies added a commit that referenced this pull request Jun 17, 2024
24.0.0 (June 17, 2024)

New feature release in the 24.0.x series.

This release is an incremental improvement on 23.2.x, with some
fixes for bugs discovered in the updated workflow.

New features include separation of HTML reports by session for subjects
with many BOLD runs, a new ``--fs-no-resume`` option to improve interoperability
with less typical FreeSurfer directories, such as those generated by longitudinal
FreeSurfer or FastSurfer, and adoption of DatasetLinks and BIDS-URIs, to follow
the recommendations of recent versions of BIDS.

With thanks to Dimitri Papadopoulos, Basile Pinsard, Celine Provins, Taylor Salo
and Wang Hao-Ting for their contributions!

* FIX: Add "double" type to allowed DisplacementFieldTransform (#3287)
* FIX: Require recent templateflow, select correct aparc dseg.tsv (#3256)
* FIX: Ensure proper templates are retrieved with sloppy (#3251)
* FIX: Delete summary from functional report when separated by sessions (#3223)
* FIX: Support lists in bids filter file containing ``null`` or ``*`` (#3215)
* FIX: Re-enable anat fasttrack for dataset without t1w (#3202)
* ENH: Use BIDSURI in init_ds_boldmask_wf (#3297)
* ENH: Add templateflow to DatasetLinks (#3267)
* ENH: Track proximal sources of functional GIFTIs (#3263)
* ENH: Support named derivative paths (#3264)
* ENH: Track Sources for standard-space outputs (#3262)
* ENH: Add --fs-no-resume option to reuse existing FreeSurfer outputs without resuming (#3142)
* ENH: Use BIDS URIs to track Sources in sidecars (#3255)
* ENH: Ignore unselected subjects in BIDSLayoutIndexer (#3236)
* ENH: Add metadata for motion parameters (#3245)
* ENH: Separate anatomical and functional reports per session for densely sampled dataset (#3191)
* ENH: Leverage T2w if available for BOLD -> anat coregistration (#3208)
* RF: Fix ITK warp conversion to nitransforms format (#3300)
* RF: Load report assembler from nireports (#3177)
* DOC: Clarify ``--dvars-spike-threshold`` uses standardized DVARS (#3205)
* TST: Update test to reflect new report generation behavior (#3210)
* STY: Manual conversions to f-strings (#3241)
* STY: Apply ruff/pyupgrade rule UP031 (#3280)
* STY: Lint and style check full repository (#3221)
* STY: Adopt ruff for linting and formatting (#3206)
* MNT: Pin libitk 5.3 and note dependencies (#3298)
* MNT: Upgrade ruff pre-commit, add fixing checks (#3283)
* MNT: Complete transition from flake8/black to ruff (#3279)
* MNT: Apply Repo-Review suggestions (#3194)
* MNT: Verbatim copy of Apache license 2.0 (#3259)
* MNT: Bump cryptography from 41.0.7 to 42.0.4 (#3234)
* MNT: Drop copyright year, unused dunder fields (#3247)
* MNT: Update environment pins (#3226)
* MNT: Bump codecov/codecov-action from 3 to 4 (#3219)
* DOCKER: Restore mincinfo binary (#3249)
* CI: Move to new circle machine tags (#3248)
* CI: Avoid ruff warning (#3244)
* CI: Pass ruff tests (#3243)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant