Simplified version of Hello-GATK #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on Adam's branch at #364
✅ Deploy Preview for nextflow-training ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
No longer needed
replaced by Adam's ref files
reolaced by Adam's BED file
For accessory file inputs
whitespace
maxulysse
reviewed
Sep 25, 2024
maxulysse
reviewed
Sep 25, 2024
maxulysse
reviewed
Sep 25, 2024
maxulysse
reviewed
Sep 25, 2024
maxulysse
reviewed
Sep 25, 2024
maxulysse
reviewed
Sep 25, 2024
adamrtalbot
requested changes
Sep 25, 2024
adamrtalbot
reviewed
Sep 25, 2024
adamrtalbot
reviewed
Sep 25, 2024
adamrtalbot
reviewed
Sep 25, 2024
Don't forget to dismiss this change request |
- add note about working directory - remove collect mention which is no longer applicable and replace with informative statement
adamrtalbot
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
On a test run everything worked.
One final point, the samplesheet should be explained fully. Each row is a path to a BAM file, which must be the absolute path.
For seqeralabs/nf-hello-gatk I will add a Github URL or S3 storage URL so we can pull the data from remote storage to a samplesheet.
A relative path works too, if you are at the right location |
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Adam's branch at #364