Support IMDSv2 when using Amazon EC2 instances #3425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan Thorpe <[email protected]>
pditommaso
reviewed
Nov 23, 2022
plugins/nf-amazon/src/main/nextflow/cloud/aws/AmazonClientFactory.groovy
Show resolved
Hide resolved
pditommaso
force-pushed
the
master
branch
2 times, most recently
from
2c461f8 to
23432f3
Compare
pditommaso
approved these changes
Nov 29, 2022
marcodelapierre
pushed a commit
to marcodelapierre/nextflow
that referenced
this pull request
Dec 5, 2022
… [ci skip] Signed-off-by: Nathan Thorpe <[email protected]> Co-authored-by: Paolo Di Tommaso <[email protected]> Signed-off-by: Marco De La Pierre <[email protected]>
l-modolo
pushed a commit
to l-modolo/nextflow
that referenced
this pull request
Jan 25, 2023
… [ci skip] Signed-off-by: Nathan Thorpe <[email protected]> Co-authored-by: Paolo Di Tommaso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #2962
Since the new AWS SDK for Java (> v1.11.678) supports IMDSv2, this changes the
fetchIamRoleandfetchRegionmethods in theAmazonClientFactoryto use the SDK's implementation to get those properties rather than querying the metadata endpoint directly.