This repository has been archived by the owner on May 10, 2021. It is now read-only.
Fix: Add support for res.redirect in API routes #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy over the files from the next-aws-lambda package and manually bundle them into our Netlify Functions. This gives us more flexibility to customize the compatibility layer between Netlify Functions and Next.js. For now, no changes have been made to the next-aws-lambda files and they have been copied as-is. next-aws-lambda source: https://github.com/serverless-nextjs/serverless-next.js/tree/master/packages/compat-layers/apigw-lambda-compat
lindsaylevine
force-pushed
the
fix-api-route-redirects
branch
from
c9c99fb to
a093007
Compare
lindsaylevine
added a commit
that referenced
this pull request
Nov 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
res.redirectin API routes as described in https://nextjs.org/docs/api-routes/response-helpersIt does this by returning the
resobject fromres.writeHead, thus allowing method chaining. This is how a ServerResponse object should behave according to https://nodejs.org/api/http.html#http_response_writehead_statuscode_statusmessage_headers. The other mock methods of theresobject probably need to be adjusted in the future, too.This PR resolves #74 (thanks for the test case, @afzalsayed96! It's the first commit in this PR 🙂 ).