Skip to content
This repository has been archived by the owner on May 10, 2021. It is now read-only.

Fix Node.js version in CI #91

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Fix Node.js version in CI #91

merged 1 commit into from
Nov 17, 2020

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Nov 17, 2020

Fixed #87.

Unfortunately, we need to use Node 10.15.0 and not 10.13.0 because Jest >=25 has a bug with Node <10.15.0, so that would force us to downgrade Jest two major releases down.

However, we should be just fine with testing 10.15.0, not many big changes happened in-between those two versions.

@ehmicky ehmicky added the type: chore work needed to keep the product and development running smoothly label Nov 17, 2020
@ehmicky ehmicky self-assigned this Nov 17, 2020
@ehmicky ehmicky mentioned this pull request Nov 17, 2020
Closed
@ehmicky ehmicky merged commit 2a7e1b2 into main Nov 17, 2020
@ehmicky ehmicky deleted the chore/node-10-13-0 branch November 17, 2020 19:46
lindsaylevine added a commit that referenced this pull request Nov 18, 2020
@lindsaylevine
Publish v2.6.3
66cc4ce 
- Fix: don't empty publish/function paths unless they're default ([#94](#94))
- Fix: add support for res.redirect in API routes ([#93](#93))
- Remove next-aws-lambda dependency (now inlined) ([#92](#92))
- Fix: Node.js version in CI ([#91](#91))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lindsaylevine lindsaylevine lindsaylevine approved these changes

Assignees

@ehmicky ehmicky

Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run tests on Node 10.13.0
2 participants
@ehmicky @lindsaylevine