When running on Windows the correct path separator must be used #386
Conversation
…Path.join is OS aware, so when we want to use forward slash use path.join instead. on windows docker cp should end with \. when copying a directory when running npm modules we should pass in path with all forward slashes This fixes nektos#331
…Linux, we need to change \ for /
…ccessful build is nektos#371, builds after that are failing
|
yes! @nektos-ci can we push a release with this fix? |
|
@timheuer - just released |
|
@cplee did y'all stop releasing to chocolatey? it's stuck on 0.2.9 |
|
@timheuer - sigh ... the chocolatey part of the build has started failing. I'm a noob with chocolately, so it will take me some time to figure out why it is failing: https://github.com/nektos/act/runs/1243421598?check_suite_focus=true |
|
Yikes, that's one heck of a log! maybe @ferventcoder can lend insight as looks like something in the docker build. |
|
From what I'm reading, it is not restoring the NuGet packages to be able to build choco. I remember that was sometimes a leader to a deeper issue but can't recall offhand what it was. Some notesLooks like this is attempting to build Chocolatey on Linux. We had some fixes and now support a newer Mono. The issue was at chocolatey/choco#1827 (comment), which was completed March 25, 2020. From the package page, that doesn't really line up well with the date this stopped working (after May 2020). Here's a couple of resources just to ensure you are building things in an appropriate manner:
Parting Thoughts"act" as a package name can be made available - the tool that was submitted never made it to approved and was ultimately rejected. I like parity of package naming across platforms, so if you want to go that route, we can show you how to deprecate the act-cli to point to the act package as you take over that. Here's the request form - https://chocolatey.org/packages/act/3.3.3.258/ContactAdmins |
…Path.join is OS aware, so when we want to use forward slash use path.join instead.
on windows docker cp should end with . when copying a directory
when running npm modules we should pass in path with all forward slashes
This fixes #331