Fix path for local node12 actions #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes here are minimal but the PR looks huge because of the node_modules. I can try making the testdata action a compiled version via ncc if that's desired. |
|
@jromero - i'd rather not have the |
Yup I can compile it as mentioned above. Given that this is more or less a static javascript app the concern of having to update it via compilation seems very minimal. I'll update the PR and squash it. |
jromero
force-pushed
the
fix/185-local-js
branch
from
bfe6994 to
986a08d
Compare
|
@cplee updated. Let me know what you think. |
Fixes nektos#185 Signed-off-by: Javier Romero <[email protected]>
jromero
force-pushed
the
fix/185-local-js
branch
from
986a08d to
d88bd46
Compare
cplee
approved these changes
Sep 29, 2020
taliesins
added a commit
to taliesins/act
that referenced
this pull request
Oct 8, 2020
…ccessful build is nektos#371, builds after that are failing
cplee
pushed a commit
that referenced
this pull request
Oct 9, 2020
* When running on Windows the correct path separator must be used. filePath.join is OS aware, so when we want to use forward slash use path.join instead. on windows docker cp should end with \. when copying a directory when running npm modules we should pass in path with all forward slashes This fixes #331 * When calculating relative folders on Windows for destination path on Linux, we need to change \ for / * Reduce complexity by extracting methods * V1 does not point to a file that does not exist * Looks like something else is the cause of this test breaking. Last successful build is #371, builds after that are failing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes makes it so that the proper path is used when executing a local javascript (
node12) action.Additional minor changes:
make testto be functional by running expectedgo testtask based on README.mdmake formatto format based on CONTRIBUTING.mdGITHUB_TOKENbe set only once instead of re-executingcatper target.expression_teststo retain previous behaviour (when no file matched) now that apackage-lock.jsonfile exists intestdata.Fixes #185