Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.0.0 #147

Merged
merged 218 commits into from
Mar 8, 2024
Merged

Release v2.0.0 #147

merged 218 commits into from
Mar 8, 2024

Conversation

snaselj
Copy link
Contributor

@snaselj snaselj commented Mar 4, 2024

Closes: NaN

What's Changed

  • Prepared for v2.0.0 release.

chadell and others added 30 commits June 29, 2022 09:26
* Update CODEOWNERS

* Update CODEOWNERS
* Fix CI & linters.

* Pin diffsync to 1.3.0

* Update diffsync, avoid RecursionError in test cases

* More attempts at fixing CI

* Tweak Nautobot versions

* Uprev diffsync

* Remove nautobot 1.0.x from test matrix as it no longer can be installed cleanly

Co-authored-by: Patryk Szulczewski <[email protected]>
Co-authored-by: Glenn Matthews <[email protected]>
Bumps [django](https://github.com/django/django) from 3.2.13 to 3.2.14.
- [Release notes](https://github.com/django/django/releases)
- [Commits](django/django@3.2.13...3.2.14)

---
updated-dependencies:
- dependency-name: django
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
* Bump oauthlib from 3.2.0 to 3.2.1

Bumps [oauthlib](https://github.com/oauthlib/oauthlib) from 3.2.0 to 3.2.1.
- [Release notes](https://github.com/oauthlib/oauthlib/releases)
- [Changelog](https://github.com/oauthlib/oauthlib/blob/master/CHANGELOG.rst)
- [Commits](oauthlib/oauthlib@v3.2.0...v3.2.1)

---
updated-dependencies:
- dependency-name: oauthlib
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* Dockerfile fixes

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Glenn Matthews <[email protected]>
* Existing docs migrated to new structure

* make mkdocs-material work with Nautobot 1.2.11

* Skip test for 1.2.x to skip mkdocs inconsistent dependencies with dev env

* Update docs

* pin nautobot version to 1.4.10

* limit to nautobot 1.3

* remove last note

* Per minor version release notes

* Apply suggestions from code review

Co-authored-by: Glenn Matthews <[email protected]>

* Apply suggestions from code review

Co-authored-by: Cristian <[email protected]>

* fix format

* pending updates

* Update lock file and fix README placeholder

* Switch nav position

* Downgrade for Nautobot 1.2 compat and enable CI

* Sync docs dependency

* Remove 3.10 from test matrix - out of scope

Co-authored-by: Christian Adell <[email protected]>
Co-authored-by: Glenn Matthews <[email protected]>
…ger (#86)

* Fix Virtual Machine Import, ensure that the vCPU Attribute is an integer

* black, flake fixes to make CI happy
* chore: Upstream testing

* fix: Replace template rests

* fix: Add invoke configurations for CI

* chore: Align compose and invoke with the template

* fix: Failing tests

* chore: Align creds.example env with the template

* chore: Do not trigger upstream testing on push

* fix: Update minimal Nautobot version to 1.4

---------

Co-authored-by: Jan Snasel <[email protected]>
* Provide a default value for Interface.type

Netbox and Nautobot have different choice options for the Interface.type
field. This defaults to using the "other" type in Nautobot when the
Netbox type is not supported by Nautobot.

* Fixup from PR review

* Fix linting

* Default all DCIM models with type field to other

* Fixup from PR feedback

* Fix linting
* Add ProviderNetwork Model

* Fix linting
* Add support for JournalEntry/Note model

This adds support for the NetBox JournalEntry Model, and maps that to
Nautobot's Note Model. NetBox has a field named kind that does not match
to a field in Nautobot, so that data will be ignored at this time.

* Fix loading via alias

* Add docs for documenting discrepancies
* Log a warning for fields defined in NetBox data not supported by DiffSync Model

* Move logging to instantiation and use warning and debug

* Move logging to NetBox only

* Clean up changes

* Add unittests

* skip some tests for py3.7

* Add combining base class ignored fields

* add nautobot_instance identifier
Template:

```
{
    "template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
    "dir": "nautobot-app",
    "ref": "develop",
    "path": null
}
```

Cookie:

```
{
    "remote": "https://github.com/nautobot/nautobot-plugin-netbox-importer.git",
    "path": "/opt/ntc/drift-manager/outputs/nautobot-plugin-netbox-importer",
    "repository_path": "/opt/ntc/drift-manager/outputs/nautobot-plugin-netbox-importer",
    "dir": "",
    "branch_prefix": "drift-manager",
    "context": {
        "codeowner_github_usernames": "@smith-ntc",
        "full_name": "Network to Code, LLC",
        "email": "[email protected]",
        "github_org": "nautobot",
        "plugin_name": "nautobot_netbox_importer",
        "verbose_name": "Nautobot NetBox Importer",
        "plugin_slug": "nautobot-netbox-importer",
        "project_slug": "nautobot-plugin-netbox-importer",
        "repo_url": "https://github.com/nautobot/nautobot-plugin-netbox-importer",
        "base_url": "netbox-importer",
        "min_nautobot_version": "1.6.0",
        "max_nautobot_version": "1.9999",
        "camel_name": "NautobotNetboxImporter",
        "project_short_description": "Data importer from NetBox 2.10.x to Nautobot.",
        "model_class_name": "None",
        "open_source_license": "Apache-2.0",
        "docs_base_url": "https://docs.nautobot.com",
        "docs_app_url": "https://docs.nautobot.com/projects/netbox-importer/en/latest",
        "_template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
        "_output_dir": "/opt/ntc/drift-manager/outputs",
        "_repo_dir": "/home/jsn/.cookiecutters/cookiecutter-nautobot-app/nautobot-app",
        "_checkout": "develop"
    },
    "base_branch": "develop",
    "remote_name": "origin",
    "pull_request_strategy": "PullRequestStrategy.CREATE",
    "post_actions": [
        "PostAction.BLACK"
    ],
    "baked_commit_ref": "",
    "draft": true
}
```

CLI Arguments:

```
{
    "cookie_dir": "",
    "input": false,
    "json_filename": "setup-cookie-netbox-importer.json",
    "output_dir": "./outputs",
    "push": true,
    "template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
    "template_dir": "nautobot-app",
    "template_ref": "develop",
    "pull_request": null,
    "post_action": [
        "black"
    ],
    "disable_post_actions": false,
    "draft": true
}
```
Cookie initialy baked by NetworkToCode Cookie Drift Manager Tool
@snaselj snaselj marked this pull request as ready for review March 4, 2024 14:26
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much impossible to comment on the code given that it's a ground-up rewrite, but I've left a few comments and nitpicks on the documentation and such.

LICENSE Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty dull icon :-)

docs/user/app_overview.md Outdated Show resolved Hide resolved
docs/user/app_use_cases.md Outdated Show resolved Hide resolved
docs/user/app_use_cases.md Show resolved Hide resolved
nautobot_netbox_importer/tests/fixtures/dump.sql Outdated Show resolved Hide resolved
nautobot_netbox_importer/utils.py Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@chadell chadell merged commit c2d3116 into main Mar 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants