-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log warning for fields in NetBox data not supported by DS Model #101
Conversation
@glennmatthews does this make sense to do? If so, is there a better way/place to do this? |
My initial concern would be over how potentially noisy this can be. Does it only log once per model, or does it log for every instance of that model? |
It logs per instance if any of the unsupported values have a value. |
Could you share the output of this change with the current data set? |
Logging once per instance feels like it could be potentially overwhelming for a large data set. Could we maybe instead log once per unsupported field, say on the first time that field is seen to have a non-empty/non-null value in the source data? Maybe as a future enhancement we could keep a counter of the number of non-empty/non-null values seen and discarded per field and report that in a summary at the end? I also like Christian's idea of auto-creating custom fields to store data that is easily represented as such. |
Other than that I think your implementation is on the right track here, doing this in the model |
Maybe we could get something in the middle? We could allow a |
cb87b0e
to
d2cd72c
Compare
@chadell @glennmatthews I refactored this in hopes to accommodate both points of feedback, outside of cleaning up some things, is there any concerns about this approach? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General approach looks reasonable to me. A few questions.
db26a3f
to
d774804
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.