Fix CustomField.type Choices #134
Conversation
snaselj
force-pushed
the
u/snaselj-napps-239-other-custom-fields
branch
from
f660b0c to
dedc375
Compare
…9-other-custom-fields
snaselj
requested review from
glennmatthews,
lampwins and
chadell
as code owners
| Nautobot 2.1 doesn't support custom field types: | ||
|
|
||
| - `object` | ||
| - `multi-object` |
There was a problem hiding this comment.
this functions is not limited to these specific types not supported, isn't it? I mean, if NetBox had a choice type abc and Nautobot doesn't have it, it will be changed to a text type?
And then, when it tries to import it, it fails with something like:
f510c5ff-e1f8-5adc-9fb5-30bc5791b42e Device 1 | ["Invalid value for custom field 'device_custom_object': Value must be a string"]
because the value is an object that is not a text. do I understand it correctly?
There was a problem hiding this comment.
Correct, just one thing is different. The ValidationIssue means that the instance has been imported to Nautobot, but there is an issue in data.
There was a problem hiding this comment.
When changing CustomField.type from e.g. abc to text, the warning is logged only. Considering adding these import warnings to ValidationIssues as well, WDYT?
There was a problem hiding this comment.
sorry Jan, not following "the warning is logged only". What else could happen?
What does it imply adding these import warning to ValidationIssues?
There was a problem hiding this comment.
In this case, the following happens:
- Import of
CustomFieldname="device_custom_object"
The field type is changed from object (not in Nautobot) to text in importer function. Only warning is logged for this change. This warning is not displayed in ValidationIssues.
When creating record in Nautobot, it passes validated_save() and no ValidationIssue is created for this record.
- Import of
Devicename="Device 1"
The final Nautobot record is saved, but doesn't pass validated_save(). For these case ValidationIssue is created.
ValidationIssues are displayed in the summary (both text and JSON), however warnings, are just logged to console. My proposal is to change this, so that these warnings from case 1. will be displayed in summary as another ValidationIssue.
There was a problem hiding this comment.
yes, my proposal would be to log the issue from (1) into (2), but not stop saving the Device only because one of the attributes can't be imported (being an optional one)
There was a problem hiding this comment.
Fine, will do this as a separate PR.
Closes: NaN
What's Changed
CustomField.typechoices.To Do