Fix Half U

[snaselj]

Closes: NaN

What's Changed

• Fixed importing non integer values for DeviceType.u_height.

To Do

• Blocked by Fix CustomFieldChoices Import #131

[glennmatthews]

How does this impact the racking of such devices? (IIRC 0U devices can't be assigned a rack position, so racked 0.5U devices may pose a problem for importing).

[snaselj]

How does this impact the racking of such devices? (IIRC 0U devices can't be assigned a rack position, so racked 0.5U devices may pose a problem for importing).

Thanks for clarification, what's your proposal on this pls.? Not sure whether remove rack assignment, fail, or try to round it to 1? Any other thoughts?

If the rack assignment would fail as a ValidationError, then it's safe to import. All ValidationErrors are gathered and printed.

[glennmatthews]

Rounding up wouldn't be any better as you'd now have two 1U devices trying to occupy the same position in the rack, which would also be invalid. Possibly the best approach would be to round down u_height as you're doing, but also un-rack any devices that either result in a zero u_height or had a non-integer position in a rack. That way the devices themselves can still be imported successfully at least.

[glennmatthews]

Unrelated change?

[snaselj]

This file is generated, don't want to change it manually.

Noticed this color field flapping. Want to fix it in a separate PR, not a real issue now.

[glennmatthews]

Unrelated change?

[snaselj]

This file is generated, don't want to change it manually.

Noticed this color field flapping. Want to fix it in a separate PR, not a real issue now.

[glennmatthews]

I question the value of this fix in isolation without also addressing the racking issue, but looks fine for what it is.