[DataGrid] Change default loading overlay variants #15504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KenanYusuf
added
breaking change
component: data grid
|
Deploy preview: https://deploy-preview-15504--material-ui-x.netlify.app/ Updated pages: |
cherniavskii
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
I was about to ask for this demo for visual regression testing 👍🏻
There was a problem hiding this comment.
I went to the docs to see this change in practice, and realized that most of our demos aren't using the loading state and show no rows overlay instead 🫠
E.g.: https://deploy-preview-15504--material-ui-x.netlify.app/x/react-data-grid/sorting/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15484
variantprop tolinear-progressandnoRowsVarianttoskeleton.DataGridProsince it is a commercial feature. Added a regression test for using skeleton loader with pinned columns to catch any regressions.