Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data grid] Change the default loading overlay variant #15484

Closed
Tracked by #13188
cherniavskii opened this issue Nov 19, 2024 · 1 comment · Fixed by #15504
Closed
Tracked by #13188

[data grid] Change the default loading overlay variant #15484

cherniavskii opened this issue Nov 19, 2024 · 1 comment · Fixed by #15504
Assignees
@KenanYusuf
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! v8.x

Comments

@cherniavskii
Copy link
Member

cherniavskii commented Nov 19, 2024 •
edited by KenanYusuf
Loading

Can we make skeleton the default value for slotProps.loadingOverlay.noRowsVariant rather than circular-progress?

And should we make linear-progress the default value for slotProps.loadingOverlay.variant?

Search keywords:
@cherniavskii cherniavskii added breaking change component: data grid This is the name of the generic UI component, not the React module! v8.x labels Nov 19, 2024
@cherniavskii cherniavskii mentioned this issue Nov 19, 2024
Open
12 tasks
@KenanYusuf KenanYusuf changed the title Change the default loading overlay variant [data grid] Change the default loading overlay variant Nov 19, 2024
@KenanYusuf KenanYusuf mentioned this issue Nov 20, 2024
Merged
@github-actions GitHub Actions
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KenanYusuf KenanYusuf

Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! v8.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DataGrid] Change default loading overlay variants KenanYusuf/mui-x
2 participants
@KenanYusuf @cherniavskii