[DataGrid] Fix undefined slot values #10934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romgrk
added
the
component: data grid
|
Deploy preview: https://deploy-preview-10934--material-ui-x.netlify.app/ |
scamden
reviewed
Nov 7, 2023
Comment on lines
+21
to
+30
| const result = { ...defaultSlots }; | ||
| Object.keys(overrides).forEach((key) => { | ||
| const k = key as keyof typeof overrides; | ||
|
|
||
| if (overrides[k] !== undefined) { | ||
| result[k] = overrides[k] as any; | ||
| } | ||
| }); | ||
|
|
||
| return result; |
There was a problem hiding this comment.
thanks for the fix! little bit less boilerplatey suggestion if you want:
Suggested change
| const result = { ...defaultSlots }; | |
| Object.keys(overrides).forEach((key) => { | |
| const k = key as keyof typeof overrides; | |
| if (overrides[k] !== undefined) { | |
| result[k] = overrides[k] as any; | |
| } | |
| }); | |
| return result; | |
| return { | |
| ...defaultSlots, | |
| ...Object.fromEntries(Object.entries(overrides).filter([k] => k !== undefined)) | |
| } |
There was a problem hiding this comment.
Doesn't seem equivalent. overrides needs to be used. And the result needs to be set to the default slot unless an override is provided.
There was a problem hiding this comment.
Object.fromEntries(Object.entries(overrides).filter(fn) is basically just a pickBy pattern, so if you all have lodash or a similar util you could reduce this code even a little bit further
cherniavskii
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10933
Allow passing
undefinedas a slot value.