[docs] Use the getLayout on the material demo pages
#41936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-41936--material-ui.netlify.app/ Bundle size report |
alexfauquette
changed the title
getLayout on the material demo pages
|
@alexfauquette What are the two condition changes doing here? Might be useful to add a comment as well, or link to a comment on this PR 😄 |
|
@bharatkashyap I don't know why it was still visible. It comes from this PR #41908 |
bharatkashyap
approved these changes
Apr 18, 2024
|
Linking with #41117 Even beyond the improved performance, I appreciate the badge and search icon who do no longer flicker on each page transition. It will be great to propage this to all pages. It's nice we do it incrementally. We will see if there are more regressions. I had to fix a bunch in the past with the "v2". |
oliviertassinari
changed the title
getLayout on the material demo pagesgetLayout on the material demo pages
oliviertassinari
added
docs
Only if someone uses next.mui.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to speed up a bit the page transition.
I recoded the time between the click and the first frame with the new page content as follow
Result
The rendering time in ms