Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Fix page change speed regression #41117

Open
danilo-leal opened this issue Feb 15, 2024 · 0 comments
Open

[docs-infra] Fix page change speed regression #41117

danilo-leal opened this issue Feb 15, 2024 · 0 comments
Assignees
Labels
bug 🐛 Something doesn't work performance priority: important This change can make a difference regression A bug, but worse scope: docs-infra Specific to the docs-infra product

Comments

@danilo-leal
Copy link
Contributor

danilo-leal commented Feb 15, 2024

The problem

The page transition speed between pages is about x3-x4 too slow.

Open https://mui.com/material-ui/react-button/ and navigate to the Button Group page. It takes about 200ms to perform the transition:

SCR-20240215-uewa

According to https://web.dev/articles/inp, this is very borderline for my high-end MacBook Pro. Google Search will use a new performance ranking metric, which we don't do well:

Screenshot 2023-08-09 at 13 36 33

https://search.google.com/search-console/core-web-vitals/summary?resource_id=sc-domain%3Amui.com&device=2#inp-table

The goal

Compare the experience to https://www.radix-ui.com/primitives/docs/components/alert-dialog to move to the Accordion page:

SCR-20240215-uget

It's x2-3 better.

Same on https://ui.shadcn.com/docs/components/button, it's at about 65ms.

SCR-20240215-uhtw

So as a developer, my first impression is: Material UI docs feels slow, then surely MUI System is not performant, I'm not using it, I want me end-users to have a great UX. To be fair, we can't really compare Material UI docs page to others, we have a lot more content on the page.

It is to be noted that it seems a regression, https://v4.mui.com/components/button-group/ is faster:

SCR-20240215-uhux

Part of the solutions

Context

This issue is meant to be closed with insights gathered after the research task

Search keywords: docs-infra, page load

@danilo-leal danilo-leal added performance status: waiting for maintainer These issues haven't been looked at yet by a maintainer enhancement This is not a bug, nor a new feature scope: docs-infra Specific to the docs-infra product labels Feb 15, 2024
@danilo-leal danilo-leal removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Feb 15, 2024
@danilo-leal danilo-leal moved this to Selected in Docs-infra Feb 15, 2024
@oliviertassinari oliviertassinari added the regression A bug, but worse label Feb 15, 2024
@oliviertassinari oliviertassinari changed the title [docs-infra] Improve page load speed [docs-infra] Fix page load speed Feb 15, 2024
@oliviertassinari oliviertassinari added priority: important This change can make a difference bug 🐛 Something doesn't work and removed enhancement This is not a bug, nor a new feature labels Oct 11, 2024
@oliviertassinari oliviertassinari changed the title [docs-infra] Fix page load speed [docs-infra] Fix page change speed Nov 24, 2024
@oliviertassinari oliviertassinari changed the title [docs-infra] Fix page change speed [docs-infra] Fix page change speed regression Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work performance priority: important This change can make a difference regression A bug, but worse scope: docs-infra Specific to the docs-infra product
Projects
Status: Selected
Development

No branches or pull requests

3 participants