Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGPURenderer: fix cache textureViews #29261

Merged
merged 1 commit into from
Aug 29, 2024
Merged

WebGPURenderer: fix cache textureViews #29261

merged 1 commit into from
Aug 29, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Aug 29, 2024 •
edited
Loading

Related issue: #29257 (comment)

Description

Fix view dimension if shared the property.

@sunag sunag added this to the r168 milestone Aug 29, 2024
@sunag sunag marked this pull request as ready for review August 29, 2024 23:00
@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
WebGLRenderer 685.4 kB (169.7 kB) 685.4 kB (169.7 kB) +0 B
WebGPURenderer 818.7 kB (221.3 kB) 818.7 kB (221.3 kB) +39 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
WebGLRenderer 462 kB (111.4 kB) 462 kB (111.4 kB) +0 B
WebGPURenderer 564.9 kB (153.4 kB) 564.9 kB (153.4 kB) +39 B

@sunag sunag merged commit 54e591c into mrdoob:dev Aug 29, 2024
12 checks passed
@sunag sunag deleted the dev-fix-example branch August 29, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r168
Development

Successfully merging this pull request may close these issues.
1 participant
@sunag