Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: cache textureViews for reuse in bindGroup #29257

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

aardgoose
Copy link
Contributor

As title.

Reduces duplicate textureView creation (webgpu_performance example from over 5000 textureViews to less than 200).

Also reordered to remove unrequired dimension selection from video texture path.

aardgoose added 2 commits August 29, 2024 09:34
Copy link

github-actions bot commented Aug 29, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
WebGLRenderer 685.4 kB (169.7 kB) 685.4 kB (169.7 kB) +0 B
WebGPURenderer 818.6 kB (221.2 kB) 818.7 kB (221.3 kB) +64 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
WebGLRenderer 462 kB (111.4 kB) 462 kB (111.4 kB) +0 B
WebGPURenderer 564.8 kB (153.4 kB) 564.9 kB (153.4 kB) +64 B

@sunag sunag merged commit 2118a40 into mrdoob:dev Aug 29, 2024
12 checks passed
@sunag
Copy link
Collaborator

sunag commented Aug 29, 2024

Hmm.. this broken webgpu_compute_audio example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants