Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodes: StereoCompositePassNode.js #29201

Merged
merged 6 commits into from
Aug 22, 2024
Merged

Conversation

cmhhelgeson
Copy link
Contributor

@cmhhelgeson cmhhelgeson commented Aug 21, 2024

Related Issue: #29184

Description

Creates a class StereoCompositePassNode.js that implements functionality shared between AnaglyphPassNode and ParallaxBarrierPassNode.js. Anaglyph and ParallaxBarrier now implement this class.

Additionally, I modified the webgpu_stereo_camera.html example slightly. Now, the user can modify the eyeSep value, demonstrating how this value affects the final output of the image.

…sitePassNode class to reuse shared functionality
Copy link

github-actions bot commented Aug 21, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
685.4 kB (169.7 kB) 685.4 kB (169.7 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
462 kB (111.4 kB) 462 kB (111.4 kB) +0 B

@cmhhelgeson
Copy link
Contributor Author

Huh, webgpu_backdrop_water is still failing.

@cmhhelgeson cmhhelgeson marked this pull request as ready for review August 21, 2024 21:14
@Mugen87 Mugen87 added this to the r168 milestone Aug 22, 2024
@Mugen87 Mugen87 merged commit c3f1d68 into mrdoob:dev Aug 22, 2024
12 checks passed
@cmhhelgeson cmhhelgeson deleted the unify_stereo_node branch September 6, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants