-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nodes: Add anaglyph and parallax barrier pass nodes. #29184
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
I'm not sure why |
Would it make sense to collapse these classes into a shared StereoPassNode or class? It seems like there's lots of shared functionality between anaglyph and parallax? |
There is already This kind of optimization is something that I would consider in a subsequent PR though. |
I've updated the screenshot for |
Thanks @Mugen87, I also didn't understand exactly what happened, but it's good to see it working again. |
Hmm... How come we're adding so many thing to |
I think it was some sort of "unspoken agreement" to add node classes in the core. We should establish a policy like in #29187 (comment) to address this issue. |
Related issue: #29173
Description
Adds pass nodes for anaglyph and parallax barrier effects. Instead of creating an example per node class, the effects are selectable in
webgpu_display_stereo
.