Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SepiaNode: Clean up #28991

Merged
merged 1 commit into from
Jul 26, 2024
Merged

SepiaNode: Clean up #28991

merged 1 commit into from
Jul 26, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jul 26, 2024

Related issue: #28961

Description

Small review, we should avoid using property() in functions, they create global variables if not inside a layout, which can make reading a little more difficult too.

@sunag sunag marked this pull request as ready for review July 26, 2024 19:31
@sunag sunag added this to the r168 milestone Jul 26, 2024
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
684 kB (169.4 kB) 684 kB (169.4 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
460.9 kB (111.2 kB) 460.9 kB (111.2 kB) +0 B

@sunag sunag mentioned this pull request Jul 26, 2024
@sunag sunag merged commit 99c2b7c into mrdoob:dev Jul 26, 2024
12 checks passed
@sunag sunag deleted the dev-sepia branch July 26, 2024 19:39
brunosimon pushed a commit to brunosimon/three.js that referenced this pull request Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant