-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nodes: Add SepiaNode #28961
Nodes: Add SepiaNode #28961
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
I think serpia could be introduced without needing a texture as a parameter, maybe just a |
Could |
I think that makes sense if we're just strictly replicating the sepia effect, but for portability between the old and new shaders I think it makes sense to keep in cases where people are deliberately pushing the value to achieve specific effects.
Were you think something more like the colorAdjustmentNode where the tslFn is only taking in a color? Or just export a tslFn directly from the file? |
Developers didn't have support for this level of abstraction before, so we had intensity and amount everywhere, but that's no longer necessary, adding them nowadays would just be adding extra code and operations. Even if this were preserved and for the sake of practicality, the feeling when looking at the code is that it should be done with
I think no class is needed for this, just export tslFn, like: export const serpia = /*@__PURE__*/ tslFn( ( [ color ] ) => {
} ); |
That makes sense, thank you for that explanation, and I'll adjust the code accordingly. |
* add SepiaNode * add node to export * fix * condense sepia into tslFn * remove SepiaNode from Node.js * Update SepiaNode.js --------- Co-authored-by: Michael Herzog <[email protected]>
Related issue:
Description
Port of GLSL Sepia Shader to node system.
Live Example