Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WGSLNodeBuilder: Fix pow() with negative base on Windows #28971

Merged
merged 4 commits into from
Jul 25, 2024
Merged

WGSLNodeBuilder: Fix pow() with negative base on Windows #28971

merged 4 commits into from
Jul 25, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jul 25, 2024

Related issue: #28955 (comment), #28969 (comment)

Description

WebGPU issue: does not support pow() with negative base on Windows.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
684 kB (169.4 kB) 684 kB (169.4 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
460.9 kB (111.2 kB) 460.9 kB (111.2 kB) +0 B

@sunag sunag added this to the r168 milestone Jul 25, 2024
@sunag
Copy link
Collaborator Author

sunag commented Jul 25, 2024

Is E2E compatible with navigator.userAgent?

@sunag sunag marked this pull request as ready for review July 25, 2024 20:42
@sunag sunag merged commit 75d9699 into mrdoob:dev Jul 25, 2024
12 checks passed
@sunag sunag deleted the dev-fix-pow branch July 25, 2024 20:42
brunosimon pushed a commit to brunosimon/three.js that referenced this pull request Jul 25, 2024
@sunag @brunosimon
WGSLNodeBuilder: Fix pow() with negative base on Windows (mrdoob#28971
fa470bc 
)

* WGSLNodeBuilder: Fix pow() with negative base on Windows

* restore tsl galaxy example

* Update webgpu_tsl_galaxy.jpg

* puppeteer: add webgpu_tsl_galaxy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r168
Development

Successfully merging this pull request may close these issues.
1 participant
@sunag