Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Add galaxy #28955

Merged
merged 6 commits into from
Jul 24, 2024
Merged

Examples: Add galaxy #28955

merged 6 commits into from
Jul 24, 2024

Conversation

brunosimon
Copy link
Contributor

Description

A simple animated WebGPU galaxy based on Three.js Journey lessons.
The first of a dozen of TSL examples.

@sunag sunag added this to the r167 milestone Jul 24, 2024
@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 24, 2024

If you plan to add more examples like that, maybe we can all name them like webgpu_tsl_*. In this case: webgpu_tsl_galaxy.

@brunosimon
Copy link
Contributor Author

Looks like the generated screenshot doesn't match.
I just run npm run make-screenshot webgpu_tsl_galaxy and then commit.
Tested from windows and MacOS.
Am I doing something wrong?

@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 24, 2024

If you have the option, generate the screenshot from a Windows device (because the CI uses Windows as well). Besides, make sure you have latest build files on your local system. They are not built automatically when generating a screenshot so make sure to run npm run build before npm run make-screenshot.

@brunosimon
Copy link
Contributor Author

All good 👍
I'll start working on the other TSL examples.

@sunag
Copy link
Collaborator

sunag commented Jul 24, 2024

Bruno did some changes because WebGPU/WGSL pow() with negative values ​​was not working on Windows, but it works on MacOS. /cc @mrdoob

@sunag sunag merged commit e241101 into mrdoob:dev Jul 24, 2024
11 checks passed
@brunosimon brunosimon deleted the dev-webgpu-galaxy branch July 25, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants