Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Fix individual bind group cache #28790

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jul 3, 2024

Related issue: #28705

Description

I'm disabling individual bind cache (vertex/shader) for now, it's fix shadow example, just the entire groups, an update in unifiers via parameter would be great, we still need to order the nodes to better take advantage of the caches too, but we're close...

@sunag sunag added this to the r167 milestone Jul 3, 2024
@sunag sunag marked this pull request as ready for review July 3, 2024 01:20
Copy link

github-actions bot commented Jul 3, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
682.2 kB (169 kB) 682.2 kB (169 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
459.4 kB (110.9 kB) 459.4 kB (110.9 kB) +0 B

@sunag sunag merged commit a476622 into mrdoob:dev Jul 3, 2024
12 checks passed
@sunag sunag deleted the dev-fix-bindgroup branch July 3, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant