InstancedMesh: Add clone and dispose method for morphTexture
#27952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
RenaudRohlinger
changed the title
morphTexture in copy methodmorphTexture
Mugen87
reviewed
Mar 20, 2024
Mugen87
approved these changes
Mar 20, 2024
This was referenced Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #27928 #27669 #27768
Description
WebGLRenderer: The copy method wasn't cloning the new
morphTextureDataTexture and the texture was never cleaned when theInstancedMeshdisposed.WebGPURenderer: When using nodes, it is possible to create instanced skinning meshes with morph targets. In such cases,
morphTextureisundefined. This update also includes a cleanup of missing code in an example.This contribution is funded by Utsubo