-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InstancedMesh: Add support for morph targets. #27669
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Clean up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The solution looks awesome now!
@Mugen87 I wrote an example using the face and it's slower than the horse but that was not unexpected. I havent pushed it in the PR or even added it in the examples list but you can check it out directly here |
Regarding the code complexity in |
@Mugen87 I took a stub at adding full morph target support as I told you on the other PR and the results were surprisingly good. I don't notice any performance difference with the horse model which has 15 targets so it seems quite performant.
Now everything is loaded on a texture including the base influence so it will support every case and the API is identical to the attribute approach. I left the example as is and will make some more to test other cases but wont push in this PR
demo here (you may need to refresh cache to be sure, output is identical to the previous one)