WebGPURenderer: Support KTX Compressed texture in the WebGL Backend #27463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sunag
reviewed
Dec 29, 2023
Mugen87
reviewed
Dec 29, 2023
This was referenced Dec 30, 2023
AdaRoseCannon
pushed a commit
to AdaRoseCannon/three.js
that referenced
this pull request
Jan 15, 2024
…rdoob#27463) * wip * cleanup webgl backend * cleanup and add silentError * cleanup WebGLTextureUtils * move textures to textureutils * remove handling error in hasFeatre
This was referenced Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The async behavior of the
initmethod of the WebGLBackend has been removed as it breaks loaders such asKTX2Loaderthat depends on a webgl context and/or the renderer to be initialized.Took the opportunity to move the texture related methods of the
WebGLBackendtoWebGLTextureUtilsto align with theWebGPUBackendarchitecture.Removed the
isGPUcheck from thewebgpu_loader_gltf_compressedas it now works with the WebGLBackend:https://raw.githack.com/renaudrohlinger/three.js/webgl-ktxsupport/examples/webgpu_loader_gltf_compressed.html
This contribution is funded by Utsubo