Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Support WebGLCubeRenderTarget #27071

Merged
merged 9 commits into from
Jan 4, 2024
Merged

Conversation

aardgoose
Copy link
Contributor

@aardgoose aardgoose commented Oct 27, 2023

Added support to render to WebGLCubeRenderTarget and fixes cubeTexture lookups for WebGL

Also adds mipmap creation for renderTarget textures and minor depthTexture handling.

@aardgoose aardgoose force-pushed the cube branch 2 times, most recently from 379db47 to a365ac8 Compare December 15, 2023 12:00
@aardgoose aardgoose force-pushed the cube branch 5 times, most recently from fc913d7 to cffdad4 Compare December 22, 2023 20:08
@aardgoose aardgoose force-pushed the cube branch 3 times, most recently from b16a52e to d14554a Compare December 22, 2023 21:44
@aardgoose aardgoose marked this pull request as ready for review December 23, 2023 11:06
@RenaudRohlinger
Copy link
Collaborator

RenaudRohlinger commented Dec 30, 2023

This one will conflict with #27463. Would be great if we can merge this one before. I will update the other PR once it's done.

@Mugen87 Mugen87 added this to the r161 milestone Dec 30, 2023
@aardgoose
Copy link
Contributor Author

/@sunag @RenaudRohlinger Rebased on recent msaa changes - does anyone use/expect msaa on cube textures?

@RenaudRohlinger
Copy link
Collaborator

Rebased on recent msaa changes - does anyone use/expect msaa on cube textures?

Considering that MSAA has never been supported on cube textures in Three.js, and we haven't received any complaints or requests for this feature ever, I suggest we refrain from implementing it at this stage. /@aardgoose

@aardgoose
Copy link
Contributor Author

@RenaudRohlinger Very happy not to add it,

@RenaudRohlinger
Copy link
Collaborator

Requires #27490 to be merged in order to fix an issue and then be able regenerates a correct version of the screenshot of webgpu_loader_gltf. /cc @sunag

@sunag sunag merged commit 7a12ec3 into mrdoob:dev Jan 4, 2024
11 checks passed
@aardgoose aardgoose deleted the cube branch January 12, 2024 14:13
AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
* cube render targets

* implemenet destroyAttribute()

* replicate WebGPU texture filtering

* missed ;

* allow tests to run

* reinstate flip

* add missing ;

* repair damage

---------

Co-authored-by: aardgoose <[email protected]>
@Methuselah96 Methuselah96 mentioned this pull request Jan 16, 2024
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants