-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FBXLoader: Fix rotation discontinuities. #27057
FBXLoader: Fix rotation discontinuities. #27057
Conversation
I can confirm that your PR fixes the issue! Great! 🎉 Still it's important to review the new code a bit more closely so let's target Side note: The maintenance of I wish we had an additional dev with FBX knowledge who could help out reviewing FBX related PRs. |
Agreed. @solinehayes Out of curiosity, is using GLB format an acceptable alternate workflow for you -- or is there a particular advantage to FBX format? |
- As per PR mrdoob/three.js#27057
Clean up.
Well, I am working in a company where we're using Maya, so we majorly use FBX. We occasionally use GLB but we prefer FBX. |
Fix #27056
Description
This PR addresses an issue in the FBXLoader where rotations with significant differences between consecutive frames were interpolated using Euler angles (each coordinate separately), which could introduce discontinuities. The proposed solution detects and corrects these discontinuities by using quaternion interpolation (taking into account possible unroll/quaternion negation), ensuring smooth rotation.