ensure that indirect clear coat is shadowed by specular ambient occlusion #26941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
|
/ping @elalish @WestLangley |
elalish
reviewed
Oct 11, 2023
| @@ -10,7 +10,14 @@ export default /* glsl */` | |||
|
|
|||
| float dotNV = saturate( dot( geometryNormal, geometryViewDir ) ); | |||
|
|
|||
| reflectedLight.indirectSpecular *= computeSpecularOcclusion( dotNV, ambientOcclusion, material.roughness ); | |||
| float specularOcclusion = computeSpecularOcclusion( dotNV, ambientOcclusion, material.roughness ); | |||
There was a problem hiding this comment.
This should use the clearcoat roughness instead, so I think you need to call the function twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #26939
When I fixed indirect sheen so that it is shadowed by ambient occlusion, I noticed that indirect clearcoat was similarly also not affected by ambient occlusion. So I have applied the same fix to clear coat as I did with sheen.
Caveat: My reuse of the specularOcclusion function is an approximation. I am not sure if it is appropriate for indirect specular, rather I think it was designed for direct specular. It is close anyhow and better than not occluding indirect clear coat.
This contribution is funded by Threekit