Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USDZLoader: Load metallic, roughness, emissive, occlusion textures and fix color spaces #26710

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

hybridherbst
Copy link
Contributor

Related issues:

Description

This PR adds USDZLoader support for metallic, roughness, emissive and occlusion textures in the respective correct color spaces. This is especially useful for files exported with USDZExporter.

With the PR, DamagedHelmet does roundtrip pretty nicely:

.glb .usdz
exported with USDZExporter
and loaded with USDZLoader)
image image

Thanks to @GitHubDragonFly for starting with #26623. This PR improves on it especially in terms of color spaces.

This PR does not fix a number of other issues with material roundtrip, notably

  • texture scale and bias (which are the USD equivalent of specifying both "metalness" and "metalnessMap" and so on)
    • also affects normalStrength, occlusionScale and so on
  • texture transforms
  • clearcoat / clearcoatRoughness / ior (can be a future PR)

This contribution is funded by Needle

@mrdoob mrdoob merged commit 5696f32 into mrdoob:dev Sep 7, 2023
@mrdoob
Copy link
Owner

mrdoob commented Sep 7, 2023

Nice!

@mrdoob
Copy link
Owner

mrdoob commented Sep 7, 2023

Is there anything left from #26623?

@hybridherbst hybridherbst deleted the fix/usdzloader-pbr-support branch September 7, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants