USDZLoader: Distinguish between text (supported) and binary (not supported) usd files and fix UV parsing #26709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
Description
The previous USDZLoader implementation looked for the first .usda file in the USDZ archive and attempted to load that, and looked for .usd files for geometry references.
This PR improves this by
It also fixes incorrect UV parsing and incorrect mesh parsing that were written against an old version of the USDZExporter (and were not actually USD spec compliant).
The PR doesn't entirely close the aforementioned issue, as there are still discrepancies between exporter and loader (the exporter supports more USD features at the moment).
This contribution is funded by Needle