Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXRLoader: Fix parseInt64() regression. #25522

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Conversation

LeviPesin
Copy link
Contributor

Fixes #25521

Description

Revert the change introduced in #24181.

@mrdoob mrdoob added this to the r150 milestone Feb 17, 2023

} else {

int = dataView.getUint32( offset.value + 4, true ) + Number( dataView.getUint32( offset.value, true ) << 32 );

Check failure

Code scanning / CodeQL

Shift out of range

Shift out of range.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mugen87 Mugen87 changed the title EXRLoader: Revert the change to parseInt64 EXRLoader: Fix parseInt64 regression. Feb 17, 2023
@Mugen87 Mugen87 changed the title EXRLoader: Fix parseInt64 regression. EXRLoader: Fix parseInt64() regression. Feb 17, 2023
@mrdoob mrdoob merged commit acb58df into mrdoob:dev Feb 20, 2023
@LeviPesin LeviPesin deleted the patch-4 branch March 9, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue #23260, #23267 reopen since the commit #24181
3 participants