Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXRLoader: handle unsupported BigInt Safari mobile #23267

Merged
merged 3 commits into from
Jan 18, 2022

Conversation

sciecode
Copy link
Contributor

@sciecode sciecode commented Jan 18, 2022

Fixed #23260

Utilizes alternative Int64 handling when DataView.prototype.getBigInt64 isn't available.

Also fixes a small mistake on my part on retrieving specification flags information, it should be properly reflecting the actual file information now.

DWAA Example - @inear please validate the example loads correctly.

@mrdoob mrdoob added this to the r137 milestone Jan 18, 2022
Signed-off-by: Guilherme Avila <[email protected]>
@mrdoob mrdoob merged commit f274b44 into mrdoob:dev Jan 18, 2022
@sciecode sciecode deleted the exrloader-int64 branch January 19, 2022 10:12
@mrdoob
Copy link
Owner

mrdoob commented Jan 26, 2022

Seems like this PR introduced a LGTM issue:
https://lgtm.com/projects/g/mrdoob/three.js/rev/f274b4464ebe9027c74918ea8ff7069b48360cf3

@sciecode
Copy link
Contributor Author

sciecode commented Jan 26, 2022

Yeah. Right-side shift is supposed to be a BigInt shift operation, not integer.

I'm working on a PR to implement Tiled EXR ( data generated mipmaps ), is ok if I ship the fix alongside that? I don't actually expect this to affect many people, as we only start needing the upper 32b if the users are loading 8K+ res images.

@mrdoob
Copy link
Owner

mrdoob commented Jan 26, 2022

I'm working on a PR to implement Tiled EXR ( data generated mipmaps ), is ok if I ship the fix alongside that?

Sounds good 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EXRLoader: Throws error in r136 on iOS below 15.1
2 participants