Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks: Fix rotation setup in updateMatrixWorld() test #25122

Merged
merged 3 commits into from
Dec 12, 2022

Conversation

diarmidmackenzie
Copy link
Contributor

Follow-on to #25112

Description

As per this comment, it would be much less confusing if the "rotation" variable was called "quaternion", seeing as that's what it is...

@diarmidmackenzie diarmidmackenzie marked this pull request as ready for review December 12, 2022 12:27
@mrdoob mrdoob added this to the r148 milestone Dec 12, 2022
@mrdoob mrdoob merged commit dcea07e into mrdoob:dev Dec 12, 2022
@diarmidmackenzie diarmidmackenzie deleted the fix-benchmark-test branch December 12, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants