Benchmarks: Fix rotation setup in updateMatrixWorld() test.
#25112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
approved these changes
Dec 11, 2022
Mugen87
changed the title
updateMatrixWorld() test.
WestLangley
reviewed
Dec 11, 2022
| @@ -11,7 +11,7 @@ | |||
| var child = new THREE.Object3D(); | |||
| child.position.copy( position ); | |||
| child.scale.copy( scale ); | |||
| child.rotation.copy( rotation ); | |||
| child.quaternion.copy( rotation ); | |||
There was a problem hiding this comment.
Let's not write code that way.
Would you like to file a PR and rename rotation to quaternion?
There was a problem hiding this comment.
Yep. Raised #25122
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: None raised (I can raise if needed, but it didn't seem necessary for such a small fix).
Description
When running the benchmark page at /test/benchmark/benchmarks.html, we see this warning in the browser:
This is because the code sets up a Quaternion, but copies it into the
rotationproperty on the Object3D, which is an Euler, not a Quaternion.Alternative fix would be to do:
Doesn't make a lot of difference, I went for this one as I believe it's marginally more efficient