Allow passing GLTFLoader into OculusHandModel/XRHandMeshModel.
#25013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
reviewed
Nov 25, 2022
Mugen87
approved these changes
Nov 25, 2022
Mugen87
changed the title
GLTFLoader into OculusHandModel/XRHandMeshModel.
|
Minor clean up 8422f32 |
|
My bad – thanks for cleaning it up! |
hybridherbst
added a commit
to needle-tools/three.js
that referenced
this pull request
Mar 27, 2023
… proper disposal, and animation * added webgl_loader_multiple as example of how to load multiple files one after each other * added bounds fitting * added FBX import as second file type example * added material upgrade of FBX materials to MeshStandardMaterial to receive IBL * fix minDistance possibly being greater than maxDistance, fix animation loading and playback * switched to animationLoop workaround for having a nicely blurred background from the environment alternative blur approach: use texture mipmaps directly. less pretty clean up, add link to PR that will introduce background bluriness fix env bluriness (harder with mipmaps), fix HDRI Haven url update screenshot replace blurred background hack with new backgroundBlurriness feat: add USDZ loading, glTF export and USDZ export, FBX material conversion USDZExporter: fix default plane anchoring orientation and add precision specifiers (mrdoob#25012) Fixes mrdoob#25011 [XR] Feat: Allow passing GLTFLoader into OculusHandModel/XRHandMeshModel (mrdoob#25013) * feat: allow passing GLTFLoader into OculusHandModel/XRHandMeshModel * apply review feedback USDZExporter: guard against missing image data in textures USDZLoader: add hierarchy support and fix loading files exported with USDZExporter GLTFExporter: guard against missing image data in textures simplify null check cleanup child name and add example for texture traversal after loading added file input button, added download button for OBJ
hybridherbst
added a commit
to needle-tools/three.js
that referenced
this pull request
Mar 30, 2023
… proper disposal, and animation * added webgl_loader_multiple as example of how to load multiple files one after each other * added bounds fitting * added FBX import as second file type example * added material upgrade of FBX materials to MeshStandardMaterial to receive IBL * fix minDistance possibly being greater than maxDistance, fix animation loading and playback * switched to animationLoop workaround for having a nicely blurred background from the environment alternative blur approach: use texture mipmaps directly. less pretty clean up, add link to PR that will introduce background bluriness fix env bluriness (harder with mipmaps), fix HDRI Haven url update screenshot replace blurred background hack with new backgroundBlurriness feat: add USDZ loading, glTF export and USDZ export, FBX material conversion USDZExporter: fix default plane anchoring orientation and add precision specifiers (mrdoob#25012) Fixes mrdoob#25011 [XR] Feat: Allow passing GLTFLoader into OculusHandModel/XRHandMeshModel (mrdoob#25013) * feat: allow passing GLTFLoader into OculusHandModel/XRHandMeshModel * apply review feedback USDZExporter: guard against missing image data in textures USDZLoader: add hierarchy support and fix loading files exported with USDZExporter GLTFExporter: guard against missing image data in textures simplify null check cleanup child name and add example for texture traversal after loading added file input button, added download button for OBJ
hybridherbst
added a commit
to needle-tools/three.js
that referenced
this pull request
May 23, 2023
… proper disposal, and animation * added webgl_loader_multiple as example of how to load multiple files one after each other * added bounds fitting * added FBX import as second file type example * added material upgrade of FBX materials to MeshStandardMaterial to receive IBL * fix minDistance possibly being greater than maxDistance, fix animation loading and playback * switched to animationLoop workaround for having a nicely blurred background from the environment alternative blur approach: use texture mipmaps directly. less pretty clean up, add link to PR that will introduce background bluriness fix env bluriness (harder with mipmaps), fix HDRI Haven url update screenshot replace blurred background hack with new backgroundBlurriness feat: add USDZ loading, glTF export and USDZ export, FBX material conversion USDZExporter: fix default plane anchoring orientation and add precision specifiers (mrdoob#25012) Fixes mrdoob#25011 [XR] Feat: Allow passing GLTFLoader into OculusHandModel/XRHandMeshModel (mrdoob#25013) * feat: allow passing GLTFLoader into OculusHandModel/XRHandMeshModel * apply review feedback USDZExporter: guard against missing image data in textures USDZLoader: add hierarchy support and fix loading files exported with USDZExporter GLTFExporter: guard against missing image data in textures simplify null check cleanup child name and add example for texture traversal after loading added file input button, added download button for OBJ
hybridherbst
added a commit
to needle-tools/three.js
that referenced
this pull request
Jun 10, 2023
… proper disposal, and animation * added webgl_loader_multiple as example of how to load multiple files one after each other * added bounds fitting * added FBX import as second file type example * added material upgrade of FBX materials to MeshStandardMaterial to receive IBL * fix minDistance possibly being greater than maxDistance, fix animation loading and playback * switched to animationLoop workaround for having a nicely blurred background from the environment alternative blur approach: use texture mipmaps directly. less pretty clean up, add link to PR that will introduce background bluriness fix env bluriness (harder with mipmaps), fix HDRI Haven url update screenshot replace blurred background hack with new backgroundBlurriness feat: add USDZ loading, glTF export and USDZ export, FBX material conversion USDZExporter: fix default plane anchoring orientation and add precision specifiers (mrdoob#25012) Fixes mrdoob#25011 [XR] Feat: Allow passing GLTFLoader into OculusHandModel/XRHandMeshModel (mrdoob#25013) * feat: allow passing GLTFLoader into OculusHandModel/XRHandMeshModel * apply review feedback USDZExporter: guard against missing image data in textures USDZLoader: add hierarchy support and fix loading files exported with USDZExporter GLTFExporter: guard against missing image data in textures simplify null check cleanup child name and add example for texture traversal after loading added file input button, added download button for OBJ
hybridherbst
added a commit
to needle-tools/three.js
that referenced
this pull request
Jul 6, 2023
… proper disposal, and animation * added webgl_loader_multiple as example of how to load multiple files one after each other * added bounds fitting * added FBX import as second file type example * added material upgrade of FBX materials to MeshStandardMaterial to receive IBL * fix minDistance possibly being greater than maxDistance, fix animation loading and playback * switched to animationLoop workaround for having a nicely blurred background from the environment alternative blur approach: use texture mipmaps directly. less pretty clean up, add link to PR that will introduce background bluriness fix env bluriness (harder with mipmaps), fix HDRI Haven url update screenshot replace blurred background hack with new backgroundBlurriness feat: add USDZ loading, glTF export and USDZ export, FBX material conversion USDZExporter: fix default plane anchoring orientation and add precision specifiers (mrdoob#25012) Fixes mrdoob#25011 [XR] Feat: Allow passing GLTFLoader into OculusHandModel/XRHandMeshModel (mrdoob#25013) * feat: allow passing GLTFLoader into OculusHandModel/XRHandMeshModel * apply review feedback USDZExporter: guard against missing image data in textures USDZLoader: add hierarchy support and fix loading files exported with USDZExporter GLTFExporter: guard against missing image data in textures simplify null check cleanup child name and add example for texture traversal after loading added file input button, added download button for OBJ fix: GLTF and USDZ exporters break with missing images in textures adjust title and description, convert OBJ mats to MeshStandardMaterial so they use IBL updated screenshot
hybridherbst
added a commit
to needle-tools/three.js
that referenced
this pull request
Sep 7, 2023
… proper disposal, and animation * added webgl_loader_multiple as example of how to load multiple files one after each other * added bounds fitting * added FBX import as second file type example * added material upgrade of FBX materials to MeshStandardMaterial to receive IBL * fix minDistance possibly being greater than maxDistance, fix animation loading and playback * switched to animationLoop workaround for having a nicely blurred background from the environment alternative blur approach: use texture mipmaps directly. less pretty clean up, add link to PR that will introduce background bluriness fix env bluriness (harder with mipmaps), fix HDRI Haven url update screenshot replace blurred background hack with new backgroundBlurriness feat: add USDZ loading, glTF export and USDZ export, FBX material conversion USDZExporter: fix default plane anchoring orientation and add precision specifiers (mrdoob#25012) Fixes mrdoob#25011 [XR] Feat: Allow passing GLTFLoader into OculusHandModel/XRHandMeshModel (mrdoob#25013) * feat: allow passing GLTFLoader into OculusHandModel/XRHandMeshModel * apply review feedback USDZExporter: guard against missing image data in textures USDZLoader: add hierarchy support and fix loading files exported with USDZExporter GLTFExporter: guard against missing image data in textures simplify null check cleanup child name and add example for texture traversal after loading added file input button, added download button for OBJ fix: GLTF and USDZ exporters break with missing images in textures adjust title and description, convert OBJ mats to MeshStandardMaterial so they use IBL updated screenshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #24857
Description
For Monster Hands, we needed to be able to load custom hand models, and since these can be rather complex we wanted to compress them as usual with etc1s+draco. The embedded GLTFLoader inside
XRHandMeshModeldoesn't have the relevant components for loading compressed meshes, so this PR allows passing an existing / externally created loader in.If that externally created loader should load the default hand models, users need to set the DEFAULT_HAND_PROFILE_PATH in their code, otherwise it's confusing when explicitly no path is wanted (loading local relative models).
cc @cabanier
This contribution is funded by Needle