Nodes: ViewportNode #24934
Merged
Nodes: ViewportNode #24934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeviPesin
reviewed
Nov 12, 2022
| import { Vector2 } from 'three'; | ||
| import { NodeUpdateType } from '../core/constants.js'; | ||
|
|
||
| let resolution; |
There was a problem hiding this comment.
Maybe we should move this variable to instances? Because it is possible that a user would want to render for different sizes.
There was a problem hiding this comment.
I thought about it, but it shouldn't happen since .update() will force the update in GPU level every time that it is called.
|
I'm going to start working on porting the computational renderer to three.js now :-) |
0b5vr
added a commit
to three-types/three-ts-types
that referenced
this pull request
Dec 19, 2022
0b5vr
added a commit
to three-types/three-ts-types
that referenced
this pull request
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This contribution is funded by Google