Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Clean up. #24808

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Docs: Clean up. #24808

merged 1 commit into from
Oct 17, 2022

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Oct 17, 2022

Related issue: #24801

Description

Updated GLTFLoader.parse() to reflect the changes of #24801

@Mugen87 Mugen87 added this to the r146 milestone Oct 17, 2022
@Mugen87 Mugen87 merged commit 9721ff3 into mrdoob:dev Oct 17, 2022
@@ -222,13 +222,13 @@ <h3>[method:this setKTX2Loader]( [param:KTX2Loader ktx2Loader] )</h3>

<h3>[method:undefined parse]( [param:ArrayBuffer data], [param:String path], [param:Function onLoad], [param:Function onError] )</h3>
<p>
[page:ArrayBuffer data] — glTF asset to parse, as an ArrayBuffer or `JSON` string.<br />
[page:ArrayBuffer data] — glTF asset to parse, as an `ArrayBuffer`, `JSON` string or object.<br />
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sidenote: The documentation is currently not able to parse multi-type definitions. So something like [page:ArrayBuffer|String|Object data]. Could be useful to update docs/page.js to support such definitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant