Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLTFLoader: Allow json objects #24801

Merged
merged 2 commits into from
Oct 17, 2022
Merged

GLTFLoader: Allow json objects #24801

merged 2 commits into from
Oct 17, 2022

Conversation

Hoodgail
Copy link
Contributor

@Hoodgail Hoodgail commented Oct 15, 2022

Fixed #24764

Description

Instead to only using buffers and strings, this pull request will also enable you to pass along parsed json objects.

This pull requests will additionally allow you to pass through parsed json objects rather than only Buffers and strings.

mrdoob#24764
@takahirox
Copy link
Collaborator

Thanks for the PR.

Please update GLTFLoader document, GLTFLoader.parse takes strings, ArrayBuffer, and Object types as the first argument.

https://threejs.org/docs/#examples/en/loaders/GLTFLoader.parse

@Mugen87
Copy link
Collaborator

Mugen87 commented Oct 17, 2022

Please update GLTFLoader document, GLTFLoader.parse takes strings, ArrayBuffer, and Object types as the first argument.

I'll merge and update the docs.

@Mugen87 Mugen87 merged commit 321106c into mrdoob:dev Oct 17, 2022
@Mugen87 Mugen87 added this to the r146 milestone Oct 17, 2022
@Mugen87 Mugen87 mentioned this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants