PropertyBinding: fix map property binding regression introduced in #24537 #24603
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
map
as target object. #24537Description
The change to allow
map
as target object unfortunately broke traversal for general objects, such as what KHR_animation_pointer (#24108) requires for animating materials – whileNodeName.map.repeat
works it brokeMaterialName.map.repeat
for animated materials since a material doesn't have a.material
property...This PR fixes that by checking if the animated object already has a
map
property, because then the indirection to.material.map
isn't needed.cc @Mugen87
Note
My preferred way to fix this would be a broader change in bind() to ensure that when an objectName is found in targetObject that is always used – but that's a separate discussion I think: