-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PropertyBinding: Allow map
as target object.
#24537
Conversation
In the JSFiddle the keyframe track name is +1 for supporting textures as property binding targets here, thanks! /cc @hybridherbst relevant to #24108 |
Yes, the keyframe track name has to start relative from the 3D object. |
Thanks! |
@Mugen87 would be nice to have this for normalMap too? |
I'm trying to think of a solution that scales well for more map types. |
@Mugen87 in case you want to take a look at all that would be needed for KHR_animation_pointer (effectively allowing all glTF properties to be animated), here's what I had to change for that: (not saying that's a great implementation, but it covers all required cases as far as I'm aware) |
Related issue: -
Description
It should be possible to animate the texture properties
offset
orrotation
like in this fiddle: https://jsfiddle.net/37mfsugc/2/However, since
map
is no part of the supported object names inPropertyBinding
, it does not work if the animation is played in context of a 3D object.The workaround would be to change the root object of the animation mixer to the texture which is problematic since animations are usually registered for 3D objects.
This PR has no effect on existing animations.