Examples: Add external subdivision demo #24397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WestLangley
reviewed
Jul 28, 2022
Mugen87
reviewed
Jul 29, 2022
Mugen87
reviewed
Jul 29, 2022
Mugen87
approved these changes
Jul 30, 2022
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* Added example file * Added subdivision example * Added subdivision example * Added subdivision screenshot * Fixed subdivision screenshot * Improved wireframe in example * Tabs * Fix version and dispose * Wrong directory, oops * Fix version and dispose
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
* Added example file * Added subdivision example * Added subdivision example * Added subdivision screenshot * Fixed subdivision screenshot * Improved wireframe in example * Tabs * Fix version and dispose * Wrong directory, oops * Fix version and dispose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #21072
Description
Adds a demo based on the three-subdivide library. This is a new implementation for users looking for a replacement for the
SubdivisionModifier, which was removed in r125 after the official switch fromGeometrytoBufferGeometry. The library is linked to via unpkg so no version has to be maintained in this project. This is done is the style discussed in #23907.Live link:
https://raw.githack.com/stevinz/three.js/external-subdivide-demo/examples/index.html?q=external#webgl_modifier_subdivision