ComputeNode: Fix usage (much more particles) #23944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
mrdoob
reviewed
Apr 26, 2022
Comment on lines
+135
to
+136
| mesh.isInstancedMesh = true; | ||
| mesh.count = particleNum; |
There was a problem hiding this comment.
Hmmm... Someday we'll have to figure out how to make a better abstraction for instancing...
There was a problem hiding this comment.
I think in something like this: #23835 (comment)
const instancedObj3d = new InstanceObject3D( mesh || sprite3d || skinnedMesh, instanceCount );
instancedObj3d.target; // mesh || sprite3d || skinnedMesh
instancedObj3d.count; // instanceCount
scene.add( instancedObj3d );
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* ComputeNode: Fix usage * cleanup * cleanup * fix const to let
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #23905
Description
The previous approach does not multiply the number of elements by
workgroupSize, now we can compute huge arrays.I updated
webgpu_computeexample and change the behavior ofComputeNode.webgpu_computenow work with, 300.000 particles.--
I created a small internal example computing vertices(position) above 16-bits and everything worked ok with
ComputeNode.three.js.examples.-.Google.Chrome.2022-04-25.18-42-51.mp4
This contribution is funded by Google via Igalia